search

svthalia / concrexit

Thalia Website built on Django.
https://thalia.nu
Other
22 stars 11 forks source link

Boolean flag as attachment filename #3699

Closed marcopus closed 1 month ago

marcopus commented 1 month ago

In the content disposition header, the attachment should probably be outside curly braces, or the variable between curly braces should be the name of the file:

https://github.com/svthalia/concrexit/blob/a69196bdbfdd7dda68500628ef8ed258f8d20262/website/thaliawebsite/storage/backend.py#L63-L65

@DeD1rk

marcopus commented 1 month ago

Closing, cause I think the attachment is used as the filename

DeD1rk commented 1 month ago

@marcopus that's right, we should probably have typehinted it as False | str or smth