Make partner events optin #524

Closed thaliawww-service closed 4 years ago

In GitLab by @joren485 on Oct 3, 2017, 22:21

One-sentence description

Only show partner events to members who have the optin checkbox checked.

Why?

Like the optin mails, not every member wants to see partner related content.

Current implementation

The partner events are shown to everyone in the calendar.

Desired implementation

Change the optin checkbox from optin for mailing to mailing and partner events.

In GitLab by @se-bastiaan on Oct 4, 2017, 10:26

I understand that some members might not want to see content from partners, but is this really a good idea? The events are not intrusive, like the opt-in mail, and there are not a lot of them. So I don't see any reason why you'd want to hide them. Are there people who have sent complaints about the events?

In GitLab by @joren485 on Oct 4, 2017, 10:47

Maybe I will start using them more actively. There are multiple companies that are interested in putting their events in our calendar. When there are multiple partner events in the calendar, I suspect people who do not want to see partner content will start complaining.

In GitLab by @se-bastiaan on Oct 4, 2017, 11:07

Mmm, okay. We can always solve this once people start complaining I think. Make this more like an experiment. If nobody cares then we do not have to add another feature.

As for the implementation, maybe we could add a cookie based button just like we did for the birthdays instead of hiding this on profiles? Partner events are also included in the app and if we add the setting to the profile then we'll also have to load that in the app to determine if we have to show them. Also adding a button in the app to hide the partner events is easier :)

In GitLab by @thomwiggers on Oct 11, 2017, 20:36

I'd rather do it like the birthdays, I do like to receive the emails but maybe I don't want to see them in my calendar.

In GitLab by @joren485 on Oct 25, 2018, 20:05

Given that partner events are not in the ical feed, this is less of a problem. I think we can close this.

In GitLab by jthijssen on Oct 27, 2018, 16:34

If we would add this option I would only do it for the partner events that we do not organize with the partner. So only the events we add to the calendar for the partner. Because I do not think this would be relevant for lunch lectures or for example laser gaming with Procam. The amount of events added to the calendar for the partner is really small though. So I think this would be quite some effort for a very small thing. If you want to add it its oké with me, but I think it is unnecessary.

In GitLab by @se-bastiaan on Oct 27, 2018, 16:39

Maybe it's relevant to note that partner events are only those that are not organised by thalia. So the events in the partner module

In GitLab by @se-bastiaan on Oct 29, 2018, 15:54

closed

svthalia / concrexit