search

svthalia / concrexit

Thalia Website built on Django.
https://thalia.nu
Other
21 stars 12 forks source link

Address validation using Google API #746

Closed thaliawww-service closed 4 years ago

thaliawww-service commented 4 years ago

In GitLab by @JobDoesburg on Oct 22, 2018, 18:45

One-sentence description

Address validation using Google API

Why?

Currently, many people enter a home address when registering for Thalia as member, that's not correct. This data however can be validated. Tom Evers wrote a python script doing this for Thabloid address labels. It checks whether the postal code matches the other data.

Current implementation

People can enter invalid data.

Suggested implementation

People receive an error message when they enter data that cannot be validated.

thaliawww-service commented 4 years ago

In GitLab by @se-bastiaan on Oct 22, 2018, 19:01

Currently, many people enter a home address when registering for Thalia events, that's not correct.

Thalia events?

thaliawww-service commented 4 years ago

In GitLab by @se-bastiaan on Oct 22, 2018, 19:03

Anyways, see #454

thaliawww-service commented 4 years ago

In GitLab by @se-bastiaan on Oct 22, 2018, 19:08

This is might be easier now, since we can validate addresses in registrations?

thaliawww-service commented 4 years ago

In GitLab by @thomwiggers on Oct 24, 2018, 20:14

@JobDoesburg generally, "technical change" is only for Technicie members. This would be a feature request.

thaliawww-service commented 4 years ago

In GitLab by @thomwiggers on Oct 24, 2018, 20:15

Google Maps does not have postal codes for all addresses, by the way...

thaliawww-service commented 4 years ago

In GitLab by @JobDoesburg on Oct 24, 2018, 20:21

Excusez moi, je ne parle pas Technicie.

Registration for the association. I don’t know what you internally call event registrations and membership registrations.

I can send you Tom Evers’s python script that does this for our thabloid. I thought he used an Google Maps API

thaliawww-service commented 4 years ago

In GitLab by @thomwiggers on Oct 25, 2018, 09:01

You may attach it to this issue. I think we had it at some point but not sure where.

It should be interesting to see if it can recognise most addresses. Google Maps generally does lag behind on new developments.

thaliawww-service commented 4 years ago

In GitLab by @se-bastiaan on Oct 27, 2018, 16:40

To explain Technicie language: registrations is the module about association registrations.

thaliawww-service commented 4 years ago

In GitLab by @se-bastiaan on Jan 24, 2019, 23:13

@JobDoesburg can you attach the python script?

thaliawww-service commented 4 years ago

In GitLab by @JobDoesburg on Jan 25, 2019, 12:57

Yes I can. This is the repo, the original script is from Tom Evers https://gitlab.science.ru.nl/tevers/address-stickers

In the LaTeX-labels branch there is some shitty code that creates a pdf create by me. Please don't laugh :)

thaliawww-service commented 4 years ago

In GitLab by @lukovdm on Sep 18, 2019, 21:09

The autocomplete of addresses at registration fixes this issue well enough.

thaliawww-service commented 4 years ago

In GitLab by @lukovdm on Sep 18, 2019, 21:09

closed