search

svtslv / nestjs-s3

S3 module for Nest
78 stars 6 forks source link

Error when using TypeScript V5 #34

Open niklas-stegmann opened 1 year ago

niklas-stegmann commented 1 year ago

Tested with TypeScript 5.1.3:

The following constructor is no longer valid in TypeScript V5:

constructor(@InjectS3() private readonly s3: S3) {}

Error message: image

svtslv commented 1 year ago

https://github.com/nestjs/nest/pull/10970

niklas-stegmann commented 1 year ago

I have installed the latest nestjs version (9.4.2). But the file "s3.decorators.d.ts" is generated incorrectly:

image

svtslv commented 1 year ago

Can you try npm i nestjs-s3@2.1.0-next.1?

niklas-stegmann commented 1 year ago

Works: image

The error is no longer displayed

beeman commented 1 year ago

Can you try npm i nestjs-s3@2.1.0-next.1?

This fixed it for me, thanks!

polotek commented 12 months ago

Will this fix be released as an official version?

mridang commented 10 months ago

I've been running into the same issue and the 2.1.0-next.1 release fixed it. When would this be released, please?

alexpizarroj commented 3 months ago

@svtslv anything we can do to help get this officially released? happy to contribute if necessary