sw17ch / data-clist

A purely functional ring data structure for Haskell.
Other
8 stars 9 forks source link

Introduce Data.CircularList.Internal and make QuickCheck a test dependency #22

Closed utdemir closed 2 years ago

utdemir commented 3 years ago

I think this closes #16. It also conflicts with #12 a bit (I guess it's fine because that issue is 5 years old).

Previously, the library itself used to depend on QuickCheck, because the 'Arbitrary' instance was defined in the main library. This is not ideal since QuickCheck itself is a relatively heavy library, so large amount of dependency footprint introduced by data-clist is actually just QuickCheck.

In order to remove the dependency, this commit does the following:

utdemir commented 2 years ago

@sw17ch, friendly ping :). Is there anything I can do to get this PR move forward?

sw17ch commented 2 years ago

Sorry for the delays. I haven't been active in the Haskell community for some time, but I was able to review this, and confirm it builds and passes tests for me locally. I'll merge this as is, and see if I can figure out how to push a new package to Hackage. Thank you.

sw17ch commented 2 years ago

New package uploaded at https://hackage.haskell.org/package/data-clist-0.2

utdemir commented 2 years ago

Thank you @sw17ch , I really appreciate this :).

sw17ch commented 2 years ago

sorry it took so long. :)