sw360 / capycli

CaPyCLI - Python scripts for software license compliance automation with SW360
Other
13 stars 7 forks source link

discuss: prevent wrong source code attachments being uploaded #100

Closed nzupan closed 1 day ago

nzupan commented 2 weeks ago

PR https://github.com/sw360/capycli/pull/92 has provided the logic that in different ways prevents .git attachments being uploaded to the SW360 or tries to correct what was considered "wrong" SW360 entry. Below are 3 main points that should be reviewed and identified if the functionality is kept or reverted and if a more generic way should be introduced.

As it was pointed out in the PR comment section, this extension brings some side effect that should be discussed. @tngraf @gernot-h

nzupan commented 2 weeks ago

Agreements as discussed:

gernot-h commented 1 week ago

Thanks, @nzupan, for taking care to document and solve this! I will review #101 now and let you know there if I still see open points.

gernot-h commented 1 day ago

Should be fixed with merge of #101. @nzupan, please reopen if there's still something to discuss.