search

sw360 / capycli

CaPyCLI - Python scripts for software license compliance automation with SW360
Other
13 stars 7 forks source link

fix: override logic of sw360 urls and rework prevention of .git upload #101

Closed nzupan closed 1 day ago

nzupan commented 2 weeks ago

This pull request addresses 1st and 2nd point of the https://github.com/sw360/capycli/issues/100 issue.

  1. It reverts the override of the source code SW360 URL when the capycli recognises the source code download URL ending with .zip, .tgz, .tar.gz, .tar.
  2. Prevention of the .git file upload is now done only for the SOURCE and SOURCE_SELF filetype (with added tests).
nzupan commented 2 weeks ago

@gernot-h feel free to have a look on the changes.

gernot-h commented 1 week ago

Thanks again, @nzupan for taking care and especially adding testcases here! As mentioned in my comments above, your testcases helped me to note that there's actually further code in CaPyCli which prevents your change from having the intended effect. Do you have time to look into this? As written above, it might already be enough to move your code down a few lines.

nzupan commented 1 week ago

@gernot-h thank you for the review and pointing out the bug. Yes, I will look into it and provide the update to the logic and the test.

gernot-h commented 1 day ago

Ready for merging from my side. @tngraf, assigning to you for final review and merge. Let me know if you don't have time.

tngraf commented 1 day ago

Thanks, @nzupan, @gernot-h