search

sw360 / capycli

CaPyCLI - Python scripts for software license compliance automation with SW360
Other
13 stars 7 forks source link

Have functionality to show the current configuration #90

Open tngraf opened 1 month ago

gernot-h commented 1 month ago

Hi @tngraf, thanks for assigning me for review here!

I assume this is only a draft and you ask for my general opinion about adding "config list"? I see a number of small issues like missing help entry, copy&paste inconsistencies etc. which I shouldn't review yet, right?

I'm still a bit undecided whether we need an own subcommand or if it would be better to add some debug output to process_cmdline instead.

In general, I'm still a bit confused about the config file feature, I think we should add some documentation e.g. about its format and in which paths capycli expects it on Linux and Windows?

On the other hand, having something like "capycli config create" might be handy, creating a self-documenting example file for you, might probably be even better than adding long Readme discussions.

gernot-h commented 1 month ago

Regarding the implementation, I would avoid duplicating the config file read code in config/list.py and probably better add the output in main/options.py (independent whether it's triggered via enabling verbose or debug output or via a special command) , so we don't risk that the implementation in config/list.py gets inconsistent to the main one and provide wrong information to the user in corner cases...

gernot-h commented 1 month ago

Reassigning back to you, @tngraf for further discussion. I could also work on improving this if you want!