search

sw360 / sw360chores

WARNING - Work in Progress - It is not Bug Free! Use with Caution. This repository contains Dockerfiles and accompanying scripts that allow deployment of sw360 via docker
Eclipse Public License 1.0
13 stars 18 forks source link

chores(dockerfiles): New lightweight and improved docker images #60

Closed bs-matil closed 4 years ago

bs-matil commented 5 years ago

We would like to seperate the thrift backend from anything else which has following advantages:

maxhbr commented 5 years ago

The long term goal is to replace the old docker images, but until all features are contained in the new approach, they will be placed in /docker-images-backend.

For testing one can follow the description in the docker-images-backend/README.md:

after building the "old" docker images and building the new docker images with

$ cd ./v2/docker-images-backend
$ docker-compose build

one can start a working deployment with: 

$ cd ./v2
$ ( cd /PATH/TO/SW360; mvn package -DskipTests )
$ find /PATH/TO/SW360/frontend -name '*.war' -exec cp -v {} ../_deploy \;
$ docker-compose -f docker-images-backend/docker-compose.yaml -f docker-images-frontend/docker-compose.yaml up

After that SW360 can be accessed on https://localhost:8443.

bs-matil commented 5 years ago

/docker-images-v2.

actually it will be /docker-images-backend

maxhbr commented 5 years ago

actually it will be /docker-images-backend

Oh, I missed the renaming. This PR should then add text to the top level README.md, and describe the situation and that there is currently redundancy.

bs-matil commented 5 years ago

can you do so? alternatively we can also rename back to v2?

kallesoranko commented 5 years ago

I did some testing with this PR and deployed sw360-backend to our internal GKE cluster. Couple of points:

maxhbr commented 5 years ago
  • In v2/docker-images-backend/backend/Dockerfile specific commit or branch have to be checked out before building since the changes with Liferay 7.

But the container here only build the backend and exclude everything from Liferay. How does the LR7 migration result in problems?

  • What is the reason why rest is not deployed to backend container? Should there be an additional container for rest?

Yes, there are other containers for rest, which are not yet contributed and waiting for the merge of this PR. They are part of the frontend.

oheger-bosch commented 4 years ago

In the SW360 tech call we talked about this PR, and the conclusion was that it should be merged. Based on this, I would then try to update the chores project to the current state of SW360.

Any objections against merging?

mcjaeger commented 4 years ago

no ...