sw5e-foundry / sw5e

SW5e System for Foundry VTT
GNU General Public License v3.0
43 stars 30 forks source link

Monster Compendium Image Path Issue #559

Closed eclay1819 closed 1 year ago

eclay1819 commented 1 year ago

Foundry VTT Version: 10.291 SW5E Version: 2.3.7 Running on RPi/Raspberry Pi OS x64

On a fresh install of SW5E, the Monster compendium isn't loading images, which seems to be due to an uppercase "...Avatar.webp", whereas the files are lowercase "...avatar.webp".

image image

Looks like it possibly happened in the "System Compendium Migration" commit in the sw5e/packs/packs/monsters.db file (not sure if that file is edited directly or generated from elsewhere). The commit before that had a lowercase "...avatar.webp", then that commit seems to have changed it to "...Avatar.webp". image

My Foundry server is loaded into a different world running DnD5E ATM, but I believe there was another compendium with the same problem - Monster Temp or something like that. I'll edit this issue once I can load back into my SW5E world and confirm.

Edit: I looked through all of the compendiums, and the only other one that seems to be affected is Fisto's Codex. @jtljac

Thanks for the great work, all!

jtljac commented 1 year ago

Fixed in #560

eclay1819 commented 1 year ago

I edited my original comment to add this, but I probably should have just added a new comment.

The Fisto Codex compendium is also affected by this image path case issue. Should I open a new issue for that one since this is already closed?

jtljac commented 1 year ago

I edited my original comment to add this, but I probably should have just added a new comment.

The Fisto Codex compendium is also affected by this image path case issue. Should I open a new issue for that one since this is already closed?

The PR should have also fixed the issues with Fisto's Codex