swager / randomForestCI

This package is DEPRECATED. Please use the packages `grf` or `ranger` instead, which have built-in confidence intervals.
https://github.com/swager/grf
MIT License
69 stars 21 forks source link

multiclass classification #6

Closed alionaBER closed 7 years ago

alionaBER commented 7 years ago

The suggested function trandforms the matrix with predictions into k matrices following a one-vs-all principle. Next, the unsertainty estimation is done for each class separately. In binary classification the estimation happens for y(x)=P(Y=1|X=x). Following this logic, k variance estimations are done, where instances of a particur class is the category of interest (positive class) and all others are negative. The output is a dataframe with predited class probabilities and variance estimates for each class.

swager commented 7 years ago

Thanks a lot; this looks like a useful extension. Before merging, could you please add a test for this to the testthat directory?

alionaBER commented 7 years ago

Please let me know if you recommend any additional tests.

swager commented 7 years ago

Looks good. Also -- and sorry for not bringing this up in my previous comment -- could you please add roxygen-style documentation for the function, like in the other functions in the package? (If you're interested, here's a reference on documentation with roxygen: http://kbroman.org/pkg_primer/pages/docs.html)

alionaBER commented 7 years ago

Thank you very much for the feedback and your prompt replies!

swager commented 7 years ago

Thanks again!