search

swagger-api / swagger-codegen-generators

Apache License 2.0
284 stars 423 forks source link

HTML clients seem to have "helloreverb" hardcoded as a fallback for missing info #140

Open yochannah opened 6 years ago

yochannah commented 6 years ago

Symptom: omit info > contact > email (or url) - This seems to validate in the swagger editor but if you generate an html client, it will be autofilled with helloreverb.com.

Affected templates: HTML and HTML2. Dynamic HTML I think is fine.

You can try reproducing it by comparing the output with and without lines 6-8 in this file

DiegoVillalpandoTR commented 2 years ago

This also happens on openapi 3.0.3 when generating html client.

bushwakko commented 1 year ago

What is even the point of the code examples that are generated? They contain no models, but do refer to them...

mattnedrich commented 11 months ago

This is still a problem - happens when generating static html documentation from a spec file.

maloewe-ona commented 2 months ago

helloreverb.com seems to be defined as default values here: https://github.com/swagger-api/swagger-codegen-generators/blob/e34685e086e0372a205563768ee80a89ec5cae3d/src/main/java/io/swagger/codegen/v3/generators/html/StaticHtmlCodegen.java#L55-L56 https://github.com/swagger-api/swagger-codegen-generators/blob/e34685e086e0372a205563768ee80a89ec5cae3d/src/main/java/io/swagger/codegen/v3/generators/html/StaticHtml2Codegen.java#L68-L69

This seems to affect quite a lot of sites; just search for hello@helloreverb.com with your favorite web search engine and you will see multiple production OpenAPI documentation pages with that e-mail address.