swagger-codegen contains a template-driven engine to generate documentation, API clients and server stubs in different languages by parsing your OpenAPI / Swagger definition.
[x] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
[ ] Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
[ ] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
Fixes in Dockerfile:
1. Updated base image
As described in #12158, the Docker build is broken since the base image was changed from Alpine to Ubuntu.
2. Added GEN_DIR as Build Argument
The WORKDIR was previously set by an environment variable GEN_DIR at build time. This setup doesn't make sense as it always resolves to the same default value, which makes the Dockerfile harder to read and prone to errors if anyone actually tries to customize this value
Assuming there's a valid reason for allowing this to be dynamically set, I've added a build argument (ARG instruction) before ENV, so it can actually be used effectively.
frantuma
commented
2 months ago
Dockerfile base image had changed from Alpine to Ubun, breaking Docker image build
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
Fixes in Dockerfile:
1. Updated base image
As described in #12158, the Docker build is broken since the base image was changed from Alpine to Ubuntu.
2. Added
GEN_DIRas Build ArgumentThe
WORKDIRwas previously set by an environment variableGEN_DIRat build time. This setup doesn't make sense as it always resolves to the same default value, which makes the Dockerfile harder to read and prone to errors if anyone actually tries to customize this value Assuming there's a valid reason for allowing this to be dynamically set, I've added a build argument (ARGinstruction) beforeENV, so it can actually be used effectively.