search

swagger-api / swagger-codegen

swagger-codegen contains a template-driven engine to generate documentation, API clients and server stubs in different languages by parsing your OpenAPI / Swagger definition.
http://swagger.io
Apache License 2.0
16.98k stars 6.03k forks source link

Run mvn formatter:format for better code style/format #4295

Open wing328 opened 7 years ago

wing328 commented 7 years ago
Description

Run mvn formatter:format for better code style/format

Swagger-codegen version

Latest master

Related PR

https://github.com/swagger-api/swagger-codegen/pull/4214

nickcmaynard commented 7 years ago

Part of #3972.

Once you've done this, I'll do the easy bits and clear up modules swagger-codegen-cli, swagger-codegen-maven-plugin and swagger-generator. swagger-codegen is going to be more of a community effort.

nickcmaynard commented 7 years ago

@wing328 are you planning on this as part of the v2.2.2 push, or sooner? I recall the plan (from #4214) was to do it after merging some v2.3.0 changes, but I'm not sure if this has ben lost.

wing328 commented 7 years ago

@nickcmaynard yes, still in our plan.

@cbornet is helping me to sync master to 2.3.0 due to some conflicts related to Java's datetime dependencies.

We'll run the formatter after the sync.

nickcmaynard commented 7 years ago

Thank you.

wing328 commented 7 years ago

UPDATE: Run mvn formatter:format for swagger generator, cli and maven-plug-in: 1e535575708f93263415ee2bbeb2f53b90f48153 eb498e23b81c56fe9656667285f67938ae72f8f0 38b072556a26cbb14682b2fc2dcb89639d8404ed

For "swagger-codegen", it will result in a lot of merge conflicts for the existing PRs. We'll do it after releasing 2.3.0 and merge more PRs to avoid spending too much time resolving merge conflicts.