[Java] Getter/Setter naming convention not followed in generated models

[mixmastered]

Description

When generating a client library (resttemplate), the getters/setters for a field xField are getXField and setXField. As per naming conventions, this is wrong: https://stackoverflow.com/questions/2948083/naming-convention-for-getters-setters-in-java

We found this issue when testing our API - the responses contained "xfield" and "xField" as jackson serializer did not match the field to the getter generated.

Swagger-codegen version

Using swagger codegen 2.3.1.

Swagger declaration file content or url

          "xField" : {
            "type" : "string"
          },

Command line used for generation

Using swagger-codegen-maven-plugin. Maven -> Generate sources

Steps to reproduce

Run generate-sources on a specification containing a field name in some object of form "xField" (a single lower case character followed by upper-case). Generated java model contains getXField() when it should be named getxField().

Suggest a fix/enhancement

Enhance whatever code creates getters and setters for fields in the specification.

[HugoMario]

hey @mixmastered, sorry for delay.

do you think you have time to propose a PR? i would address this, but i'm really busy with other issues :( anyway in case you can't i think i can address this in a couple of weeks.

I think changes here must be ported to 3.0.0 too.

[gregas]

Oh, cum on.

Why closing https://github.com/swagger-api/swagger-codegen/pull/9129 when it was actually providing a correction.

Was merged into forked project OpenAPITools / openapi-generator

• https://github.com/OpenAPITools/openapi-generator/issues/2085
• https://github.com/OpenAPITools/openapi-generator/pull/2095

And as we tested it there is working as expected - and according to the CONVENTIONS. But unfortunately, we can not just switch to another project - has other constraints.

So, what swagger-api/swagger-codegen provides is NOT according to Java/Beans conventions, and is plain wrong - see how many related open issues you have related to this topic, wrong getter/setter naming.

This is JAVA basics, should be fixed as critical, and not neglected for so long.

( there are many great topics how should be done

• https://stackoverflow.com/questions/40822397/why-does-propertydescriptor-return-a-property-name-with-uppercase-as-first-chara
• https://download.oracle.com/otn-pub/jcp/7224-javabeans-1.01-fr-spec-oth-JSpec/beans.101.pdf?AuthParam=1548672501_cd9f95cc049ee0220b70f6c448b2a095 (chapter 8)
• https://dertompson.com/2013/04/29/java-bean-getterssetters/
• .... )

[HugoMario]

Hello @gregas, if you are willing to resume that PR i can help you to merge it, please , let me know