[Swift] Alamofire client template does not support concurrent request

[jrcmramos]

Description

The current Alamofire client template implementation does not support concurrent requests. The static AlamofireRequestBuilder.execute method adds an instance of Alamofire.SessionManager to a global variable (managerStore) without any thread safe mechanism to avoid concurrent accesses. Therefore this can result, for example, in the deallocation of a Alamofire.SessionManager that might cancel the request. As result, the requests affect will return Error Domain=NSURLErrorDomain Code=-999 "cancelled".

Swagger-codegen version

2.3.1, 3.0.5

Swagger declaration file content or url

Not needed, all applications making concurrent requests using the Alamofire implementation of these version should experience the same issues.

Command line used for generation

swagger-codegen-2.3.1 generate -i http://localhost:8083/api-docs/v1/swagger.json -l swift4 -o swagger-client

Steps to reproduce

Dispatch several concurrent operation to a OperationQueue performing different API requests. Check if any of these calls resulted in a cancelled request.

Suggest a fix/enhancement

I can think about two different solutions that could help in the resolution of this problem:

• Instead of using static methods, relying on global variables/state and create on each request a new session manager, we could instead use an API Client instance that would be injected/kept in memory and configurable as needed.

• Make the global variable thread safe. We could use something like this:

  public final class Synchronized<T> {
  
  private let queue: DispatchQueue
  private var _value: T
  
  public init(_ value: T) {
      let queueLabel = "com.codegen.synchronized.\(type(of: value)).\(UUID().uuidString)"
      self.queue = DispatchQueue(label: queueLabel, attributes: .concurrent)
      self._value = value
  }
  
  public var value: T {
      var result: T? = nil
      queue.sync { result = self._value }
      return result!
  }
  
  public func write(using block: @escaping (inout T) -> Void) {
      queue.async(flags: .barrier) {
          block(&self._value)
      }
  }
  }

[keithcml]

I hit the same issue, how to fix!? any workaround??

[jrcmramos]

As far as I am concerned, we cannot use another Alamofire client without touching the existing template or creating a new one.

[AMiketta]

i have done a quick fix for that in my pull request https://github.com/swagger-api/swagger-codegen/pull/9499