swagger-api / swagger-core

Examples and server integrations for generating the Swagger API Specification, which enables easy access to your REST API
http://swagger.io
Apache License 2.0
7.39k stars 2.19k forks source link

[develop 2.0] consider removing scala as test dependency #804

Closed fehguy closed 9 years ago

fehguy commented 9 years ago

The tests are much easier to write with scala + scalatest, but it may be friendlier to developers to remove that and move to a pure java test framework.

adrianbk commented 9 years ago

Have you guys considered spock? It's an awesome testing framework.

https://github.com/martypitt/swagger-springmvc/blob/master/swagger-models/src/test/groovy/com/mangofactory/swagger/models/dto/ApiInfoSpec.groovy

fehguy commented 9 years ago

Will definitely take a look. I get dizzy just thinking about going back to pure junit assertions.

webron commented 9 years ago

Umm, definitely not junit. If anything TestNG. Spock is probably worth looking at.

fehguy commented 9 years ago

I'm not going to do this for M1, will push to M2 and reconsider then.

martoe commented 9 years ago

+1 for spock - a great tool for writing simple yet expressive tests

t1 commented 9 years ago

Spoc is nice, but it requires Groovy, which is also fine, but poses the same downside as scalatest requiring Scala.

I recently stumbled over assertj and started to use it in some of my projects. It makes writing very good assertions really easy. IMHO, using this makes a bigger difference than using TestNG of JUnit.

webron commented 9 years ago

Well, we decided to go with TestNG for now.

t1 commented 9 years ago

TestNG is great, and assertj augments it nicely :-)