search

swagger-api / swagger-js

Javascript library to connect to swagger-enabled APIs via browser or nodejs
http://swagger.io
Apache License 2.0
2.6k stars 754 forks source link

Allow passing baseURL to Swagger.exeute method. #3537

Open sauravazad opened 1 month ago

sauravazad commented 1 month ago

Content & configuration

Swagger-Client usage:

 SwaggerClient.execute({
  baseURL: 'someURL'
 })

Is your feature request related to a problem?

baseURL is computed every time when an execute is invoked . https://github.com/swagger-api/swagger-js/blob/ee7fdd67a1369cdb90056ad96751ac97c9c31131/src/execute/index.js#L313

Please have a look at below flame chart . Building the URL consumes almost 75% of execution time for the executeClient method .

image

Describe the solution you'd like

If SwaggerClient.execute() were to accept a baseURL , and use it if provided instead of building it , It would help in improving the performance and execution time .

Please let me know if this added support is acceptable . If so, I will raise a PR to add the support.

sauravazad commented 1 month ago

@char0n

Any comments or thought on the above proposal ?