search

swagger-api / swagger-node

Swagger module for node.js
http://swagger.io
Apache License 2.0
3.97k stars 584 forks source link

swagger-editor latest version breaks tests #393

Open helmoski opened 8 years ago

helmoski commented 8 years ago

swagger-editor v2.10.1 was released on May 11. It breaks the swagger-node tests. The tests still pass for v2.9.9.

Here is the output of running npm test with v2.10.1:

screen shot 2016-06-22 at 4 13 51 pm

fehguy commented 8 years ago

@saharj @mohsen1 do you have any ideas on this?

mohsen1 commented 8 years ago

What is swagger-engine?!

fehguy commented 8 years ago

I think this is just for swagger-node, and for whatever reason it can't find swagger-editor. I've seen that some people are adding an empty index.js file in the swagger-editor dependency?

mohsen1 commented 8 years ago

swagger-editor is a set of static files.

helmoski commented 8 years ago

@mohsen1 My mistake, I've updated the issue to say swagger-editor

mohsen1 commented 8 years ago

I don't remember most of this haha but I think this was the fix for the new version of editor: https://github.com/swagger-api/swagger-node/commit/103b833894965655765e157edd5ae3ca819f5ee9 Make sure you have that change as well

helmoski commented 8 years ago

I tried updating config/index.js with the change in 103b833, but am still getting the same error.