search

swagger-api / swagger-parser

Swagger Spec to Java POJOs
http://swagger.io
Apache License 2.0
774 stars 526 forks source link

parser-v3: Fix incorrect path separators when resolving schema ref on Windows OS (issue 1886) #1959

Closed walaniam closed 4 months ago

walaniam commented 11 months ago

This PR is to fix issue 1886

When parsing openapi definitions the results are different on Linux and Windows systems. It has been documented with the test: OpenAPIV3ParserTest#testIssue1886.

On Linux OS the schemas (with and without the fix) are resolved to: ArrayPojo, Enum1, Enum1_1, Enum2, Enum3, MapPojo, SetPojo, SimplePojo, TransactionsPatchRequestBody, additional-properties, array-pojo, locale-translation-item, map-pojo, set-pojo, simple-pojo, translation-item

On Windows OS, without this fix, schemas are resolved to following names: ArrayPojo, Enum1, Enum2, Enum3, MapPojo, SetPojo, SimplePojo, TransactionsPatchRequestBody, schemas\array-pojo, schemas\enum1, schemas\map-pojo, schemas\set-pojo, schemas\simple-pojo

dexterxx-pl commented 4 months ago

Yo, Any chances pushing this PR / updating it?

walaniam commented 4 months ago

@dexterxx-pl I have opened a new clean one https://github.com/swagger-api/swagger-parser/pull/2064