swagger-api / swagger-parser

Swagger Spec to Java POJOs
http://swagger.io
Apache License 2.0
780 stars 525 forks source link

Fix ref handling in CB, AnyOf & examples (fixes : #2086) #2087

Open anthochristen opened 5 months ago

anthochristen commented 5 months ago

This PR is to address the $ref handling issues in callbacks and discriminator mapping objects as detailed in #2086. It does it with the following changes

Each done in dedicated commits, although there might be some spill over.

anthochristen commented 5 months ago

@gracekarina I see that you have worked on the files in which most of this changes are done for this issue (#2086). Would be great if you can take a look at these changes.

anthochristen commented 5 months ago

Have a blanket IT type test for now, can add more in depth UTs once I get some comments on these changes.

anthochristen commented 5 months ago

Thanks @frantuma for assigning this to yourself!

anthochristen commented 4 months ago

P.S: These issues are not present in the npm swagger-parser lib.

anthochristen commented 4 months ago

@frantuma I've changed the oneOf and anyOf to be inclusive, kindly help take a look when possible, thanks!