search

swagger-api / swagger-play

Apache License 2.0
330 stars 181 forks source link

Handle route delegation properly #132

Open larochef opened 7 years ago

larochef commented 7 years ago

When a set of routes is delegated to another router, there is a missing "/" between the prefix of the delegated route and the last part of the route.

For instance:

->       /endpoint        myEndpoint.router.Routes

and in the myEndpoint.router.routes:

GET    /my/endpoint     ....

would end up with url /endpointmy/endpoint insead of /endpoint/my/endpoint

pjfanning commented 7 years ago

@larochef could you add some test cases?

larochef commented 7 years ago

@pjfanning i'll have a look at how the delegation can be done in tests

larochef commented 7 years ago

@pjfanning I've added some tests, they helped me see some forgotten cases.

larochef commented 7 years ago

@pjfanning did you get a chance to have a look at it ?

pjfanning commented 7 years ago

@larochef your change looks ok to me but you'll need a Member to review and merge

JFCote commented 7 years ago

I have the same problem and would like this fix. Is it going to be merged soon and released to maven ?