Open ghost opened 3 years ago
Hi @satprpa thank you for pushing the a11y agenda! To see where we're at, I took a look at https://github.com/swagger-api/swagger-ui/issues/5290 and at least some of the items appear to be resolved (Chrome 90, Linux/Gnome3). I'd like to find time to test more, particularly around screen readers and the contrast ratios.
May I ask a few questions?
Critical
issue in the above report, how can it be reproduced? It appears to work for me.As far as PRs go, large ones are harder to get merged than smaller ones. Smaller PRs are able to get reviewed/addressed much quicker. If there are features that aren't applicable to the project it may be feasible to build them into a plugin, so that you don't need to maintain a private fork (which can be PITA :D ). Cast your eyes across the plugin system to see what's possible: https://github.com/swagger-api/swagger-ui/blob/master/docs/customization/plugin-api.md
And once again, thank you for helping more people with their APIs through accessibility! cc @frantuma @char0n
Hello @ponelat ,
Thanks a lot for your response. Pls find response to your questions below.
How was the report above produced? We have used following tools to check/report these issues.
Do you know if the JAWS/NVDA tools provide suggestions on what would fix their issues? (I'm unfamiliar with these tools, but hopefully they suggest semantic fixes that are general). They don't suggest what needs to be done. But it's simple, it should read and interact with text and buttons etc. on the screen.
Given there is one Critical issue in the above report, how can it be reproduced? It appears to work for me. I will share recorded video of all the issues soon for your reference (working on that). It will be very easy for you to understand what we are talking about or will arrange one discussion.
Are you able to link to your fork or is it to remain private for now? This is something I can't share at the moment since it's private. I will work on this further to share the changes with you post our discussion.
Hope it clarifies your queries. Looking forward to collaberate on these issues with you soon!
Hello @ponelat,
PFA document, it contains all these issues with repro steps, expected behavior, evidence videos etc.
https://drive.google.com/file/d/1jET5FqdZZ3EcqqoNj3BncWe_DqZcXNgE/view?usp=sharing
Would love to have a call if you are interested. We can discuss the plan to fix all of these issues. Pls let me know.
cc: @frantuma @char0n
Note: Pls open the above URL by copying & pasting the link in a different tab rather than clicking on it directly
Hello @ponelat ,
Any update on this?
cc: @frantuma @char0n
@satprpa you did a great job mapping the issues; please give us some time to properly analyze your evidence provided in attached google doc. We're looking into it now.
Hello @char0n Have you guys done any progress on these issues? If yes can you pls share the release plan/date? Thanks
@frantuma @ponelat
@satprpa thanks for your patience. Will update you soon on this issue, and the steps we can do going forward.
@satprpa if you're on Twitter, could you reach out and we can organize a chat? My handle is https://twitter.com/jponelat
Hey @ponelat I followed you on twitter. Pls follow me back with this handle https://twitter.com/spparida. Then we can start chat I believe.
As discussed, going to start with a PR for keyboard navigation and work from there. Looking forward to the collaboration!
I think, in order to make the UI accessible, we first need to fix elementary errors in the HTML markup.
Consider servers dropdown.
<div>
<span class="servers-title">Servers</span>
<div class="servers">
<label for="servers">
<select>
<option value="https://example.com">https://example.com - Production Server</option>
</select>
</label>
</div>
</div>
Why was it done this way?
Most of accessibility violations will disappear once we bring the markup in compliance with the HTML specification.
Are the above issues being dealt with or is there a reason this has gone stale?
We use Sort Site and are getting multiple Level A accessibility violations. Should we file a new issue to get these addressed?
Hi, I would like to confirm what is the expected ETA for fixing accessibility issues for Swagger UI. We have Mutiple issues for Swagger, it seems all swagger UI accessibility issues are merged here. It would be helpful if we can have a tentative ETA or progress status on these issues?
Content & configuration
Is your feature request related to a problem?
Hi Team, We have taken a strong dependency on swagger-ui-dist package in one of our projects. When we went through the accessibility compliance review, we received 28 sev1/sev2 issues. We have observed similar requests earlier raised by other developers, but it's not addressed for 2+ years yet.
https://github.com/swagger-api/swagger-ui/issues/5290 https://github.com/swagger-api/swagger-ui/issues/5248
I just want to know why these accessibility issues are not yet addressed? is there any specific reason?
Describe the solution you'd like
Since these issues are not taking care of for so long we are afraid to raise the PR and keep waiting. Is there any plan to address these accessibility-related PRs?
Describe alternatives you've considered
Currently, we are using one private fork to address these issues by knowing we will have maintenance challenges etc.
Additional context
Issue list for reference: