search

swagger-api / sway-worker

4 stars 16 forks source link

Why are we only returning `definitionsFullyResolved` and ignoring `definitions`? #5

Open ponelat opened 8 years ago

ponelat commented 8 years ago

I referring to this... https://github.com/swagger-api/sway-worker/blob/master/index.js#L28-L39 If there are errors we return either defintionsFullyResolved or defintions If there are no errors we only return defintionsFullyResolved

Is this intentional? I'm curious, because defintionsFullyResolved isn't populate in my case. Could this be a sway issue?

mohsen1 commented 8 years ago

@whitlockjc can you comment on this?

whitlockjc commented 8 years ago

The only reason definitionFullyResolved doesn't get populated is if JsonRefs#resolveRefs fails. Update your Sway.create(...).catch(function (err) { console.log(err.stack); }); to see what is up.

ponelat commented 8 years ago

ok, thanks I will. And if its interesting, I'll post back.

whitlockjc commented 8 years ago

Let me know if I can help.

ponelat commented 8 years ago

Bah, I can't get my system to work, I'n going to bed. @whitlockjc I'll see if I can't reproduce my case, and see what is happening... its most likely my configuration of the projects that's tripping me up.

Thanks for the help, @mohsen1 @whitlockjc