search

swaggest / json-diff

JSON diff/rearrange/patch/pointer library for PHP
MIT License
220 stars 30 forks source link

Update dependencies #26

Closed techieforfun closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #26 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files           9        9           
  Lines         468      468           
=======================================
  Hits          449      449           
  Misses         19       19

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 203014d...5a39b5b. Read the comment docs.

vearutop commented 5 years ago

@TechieForFun could you please address https://github.com/swaggest/json-diff/issues/27 here by removing

    "phpunit/php-code-coverage": "2.2.4",
    "codeclimate/php-test-reporter": "^0.4.0"

from dev deps?

techieforfun commented 5 years ago

@vearutop sure, but please note there is still a problem with this version of phpunit that is abandoned package phpunit/phpunit-mock-objects, which has no replacement. but as you mentioned in #27 because lib is still gonna support this version of php it should be there.