search

swaggest / json-diff

JSON diff/rearrange/patch/pointer library for PHP
MIT License
220 stars 30 forks source link

Add PHP 8.4 support #69

Open cedric-anne opened 3 months ago

cedric-anne commented 3 months ago

Implicitly nullable parameter declarations are deprecated in PHP 8.4. The proposed change is safe and is not considered by PHP as a signature change, see https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Unfortunately, this syntax is compatible only with PHP >= 7.1. I propose to raise the minimal PHP requirement to 7.1.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.99%. Comparing base (17bfc66) to head (ece85d8). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #69 +/- ## ========================================== + Coverage 96.96% 96.99% +0.03% ========================================== Files 15 15 Lines 593 599 +6 ========================================== + Hits 575 581 +6 Misses 18 18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cedric-anne commented 2 months ago

Ping @vearutop .

The deprecation warning on PHP 8.4 is preventing us to active our CI checks on this incoming PHP version. We could still apply manually a patch, but we would prefer to help to fix it in your lib directly.