search

swaggest / jsonschema-go

JSON Schema mapping for Go
https://pkg.go.dev/github.com/swaggest/jsonschema-go
MIT License
102 stars 13 forks source link

Fix self-references #100

Closed vearutop closed 7 months ago

vearutop commented 7 months ago

Fixes https://github.com/swaggest/openapi-go/issues/89.

github-actions[bot] commented 7 months ago

Lines Of Code

Language Files Lines Code Comments Blanks Complexity Bytes
Go 7 2291 1551 269 471 601 (+3) 55.3K (+56B)
Go (test) 13 3310 (+51) 2435 (+42) 305 570 (+9) 51 83K (+1.1K)
github-actions[bot] commented 7 months ago

Go API Changes

# summary
Inferred base version: v0.3.62
Suggested version: v0.3.63
github-actions[bot] commented 7 months ago

Benchmark Result

Benchmark diff with base branch ``` Module github.com/bool64/dev not found, downloading. name old time/op new time/op delta Schema_UnmarshalJSON_raw-4 61.3µs ± 2% 61.3µs ± 2% ~ (p=0.429 n=5+6) Schema_UnmarshalJSON-4 502µs ± 0% 505µs ± 1% +0.67% (p=0.030 n=6+5) Schema_MarshalJSON_raw-4 50.0µs ± 0% 49.8µs ± 2% ~ (p=0.247 n=5+6) Schema_MarshalJSON-4 182µs ± 1% 184µs ± 1% +1.36% (p=0.004 n=6+6) name old alloc/op new alloc/op delta Schema_UnmarshalJSON_raw-4 31.6kB ± 0% 31.6kB ± 0% ~ (p=0.732 n=6+6) Schema_UnmarshalJSON-4 184kB ± 0% 184kB ± 0% ~ (all equal) Schema_MarshalJSON_raw-4 21.9kB ± 0% 21.9kB ± 0% ~ (all equal) Schema_MarshalJSON-4 55.4kB ± 0% 55.4kB ± 0% ~ (p=0.355 n=6+5) name old allocs/op new allocs/op delta Schema_UnmarshalJSON_raw-4 457 ± 0% 457 ± 0% ~ (all equal) Schema_UnmarshalJSON-4 2.00k ± 0% 2.00k ± 0% ~ (all equal) Schema_MarshalJSON_raw-4 484 ± 0% 484 ± 0% ~ (all equal) Schema_MarshalJSON-4 477 ± 0% 477 ± 0% ~ (all equal) ```
Benchmark result ``` name time/op Schema_UnmarshalJSON_raw-4 61.3µs ± 2% Schema_UnmarshalJSON-4 505µs ± 1% Schema_MarshalJSON_raw-4 49.8µs ± 2% Schema_MarshalJSON-4 184µs ± 1% name alloc/op Schema_UnmarshalJSON_raw-4 31.6kB ± 0% Schema_UnmarshalJSON-4 184kB ± 0% Schema_MarshalJSON_raw-4 21.9kB ± 0% Schema_MarshalJSON-4 55.4kB ± 0% name allocs/op Schema_UnmarshalJSON_raw-4 457 ± 0% Schema_UnmarshalJSON-4 2.00k ± 0% Schema_MarshalJSON_raw-4 484 ± 0% Schema_MarshalJSON-4 477 ± 0% ```
github-actions[bot] commented 7 months ago

Unit Test Coverage

total: (statements) 78.7% changed lines: (statements) 100.0%

Coverage of changed lines | File | Function | Coverage | |----------------|----------------|----------| | Total | | 100.0% | | reflect.go | | 100.0% | | reflect.go:241 | Reflect | 100.0% | | reflect.go:373 | reflect | 100.0% | | reflect.go:832 | makeFields | 100.0% | | reflect.go:877 | walkProperties | 100.0% |
Coverage diff with base branch No changes in coverage.
codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7bb896f) 73.70% compared to head (ff60a96) 73.67%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #100 +/- ## ========================================== - Coverage 73.70% 73.67% -0.03% ========================================== Files 7 7 Lines 1194 1193 -1 ========================================== - Hits 880 879 -1 Misses 243 243 Partials 71 71 ``` | [Flag](https://app.codecov.io/gh/swaggest/jsonschema-go/pull/100/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=swaggest) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/swaggest/jsonschema-go/pull/100/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=swaggest) | `73.67% <100.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=swaggest#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.