search

swaggest / jsonschema-go

JSON Schema mapping for Go
https://pkg.go.dev/github.com/swaggest/jsonschema-go
MIT License
102 stars 13 forks source link

Fix regression on multi tag struct processing #102

Closed vearutop closed 7 months ago

github-actions[bot] commented 7 months ago

Lines Of Code

Language Files Lines Code Comments Blanks Complexity Bytes
Go 7 2316 1568 270 478 608 (-2) 55.6K (-19B)
Go (test) 13 3362 (+40) 2474 (+35) 308 580 (+5) 51 84.6K (+1.4K)
github-actions[bot] commented 7 months ago

Go API Changes

# summary
Inferred base version: v0.3.63
Suggested version: v0.3.64
github-actions[bot] commented 7 months ago

Unit Test Coverage

total: (statements) 79.0% changed lines: (statements) 100.0%

Coverage of changed lines | File | Function | Coverage | |----------------|----------------|----------| | Total | | 100.0% | | reflect.go | | 100.0% | | reflect.go:902 | walkProperties | 100.0% |
Coverage diff with base branch No changes in coverage.
codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4871f98) 73.98% compared to head (d89aca7) 73.98%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #102 +/- ## ======================================= Coverage 73.98% 73.98% ======================================= Files 7 7 Lines 1207 1207 ======================================= Hits 893 893 Misses 243 243 Partials 71 71 ``` | [Flag](https://app.codecov.io/gh/swaggest/jsonschema-go/pull/102/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=swaggest) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/swaggest/jsonschema-go/pull/102/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=swaggest) | `73.98% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=swaggest#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 7 months ago

Benchmark Result

Benchmark diff with base branch ``` Module github.com/bool64/dev not found, downloading. name old time/op new time/op delta Schema_UnmarshalJSON_raw-4 62.0µs ± 0% 63.0µs ± 2% +1.70% (p=0.004 n=5+6) Schema_UnmarshalJSON-4 514µs ± 1% 512µs ± 1% ~ (p=0.662 n=6+5) Schema_MarshalJSON_raw-4 51.1µs ± 0% 51.4µs ± 0% ~ (p=0.052 n=5+6) Schema_MarshalJSON-4 187µs ± 1% 186µs ± 1% ~ (p=0.310 n=6+6) name old alloc/op new alloc/op delta Schema_UnmarshalJSON_raw-4 31.6kB ± 0% 31.6kB ± 0% -0.01% (p=0.043 n=6+5) Schema_UnmarshalJSON-4 184kB ± 0% 184kB ± 0% ~ (all equal) Schema_MarshalJSON_raw-4 21.9kB ± 0% 21.9kB ± 0% ~ (p=1.000 n=6+6) Schema_MarshalJSON-4 55.4kB ± 0% 55.4kB ± 0% ~ (p=0.238 n=6+5) name old allocs/op new allocs/op delta Schema_UnmarshalJSON_raw-4 457 ± 0% 457 ± 0% ~ (all equal) Schema_UnmarshalJSON-4 2.00k ± 0% 2.00k ± 0% ~ (all equal) Schema_MarshalJSON_raw-4 484 ± 0% 484 ± 0% ~ (all equal) Schema_MarshalJSON-4 477 ± 0% 477 ± 0% ~ (all equal) ```
Benchmark result ``` name time/op Schema_UnmarshalJSON_raw-4 63.0µs ± 2% Schema_UnmarshalJSON-4 512µs ± 1% Schema_MarshalJSON_raw-4 51.4µs ± 0% Schema_MarshalJSON-4 186µs ± 1% name alloc/op Schema_UnmarshalJSON_raw-4 31.6kB ± 0% Schema_UnmarshalJSON-4 184kB ± 0% Schema_MarshalJSON_raw-4 21.9kB ± 0% Schema_MarshalJSON-4 55.4kB ± 0% name allocs/op Schema_UnmarshalJSON_raw-4 457 ± 0% Schema_UnmarshalJSON-4 2.00k ± 0% Schema_MarshalJSON_raw-4 484 ± 0% Schema_MarshalJSON-4 477 ± 0% ```