search

swaggest / php-json-schema

High definition PHP structures with JSON-schema based validation
MIT License
438 stars 50 forks source link

Make InvalidRef a critical exception to avoid suppression #122

Closed vearutop closed 3 years ago

vearutop commented 3 years ago

Fixes https://github.com/swaggest/php-swagger2-schema/issues/8 one more time.

github-actions[bot] commented 3 years ago

Lines Of Code

Language Files Lines Code Comments Blanks Complexity Bytes
Makefile 1 32 23 0 9 7 2K (+3B)
Markdown 2 594 (+6) 466 (+4) 0 128 (+2) 0 19.1K (+190B)
PHP 133 11066 (+59) 8009 (+53) 1468 1589 (+6) 553 (-1) 319.6K (-1.3K)
YAML 4 (+2) 147 (+85) 132 (+79) 1 14 (+6) 0 3.6K (+2.3K)
codecov[bot] commented 3 years ago

Codecov Report

Merging #122 (3d82e48) into master (07e8698) will increase coverage by 2.32%. The diff coverage is 95.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #122      +/-   ##
============================================
+ Coverage     90.01%   92.34%   +2.32%     
- Complexity        0      756     +756     
============================================
  Files            27       27              
  Lines          1603     1645      +42     
============================================
+ Hits           1443     1519      +76     
+ Misses          160      126      -34
Impacted Files Coverage Δ
src/RefResolver.php 96.58% <75.00%> (+0.92%) :arrow_up:
src/Structure/ClassStructureTrait.php 95.71% <92.30%> (-0.84%) :arrow_down:
src/Schema.php 95.92% <97.43%> (+1.21%) :arrow_up:
src/Constraint/Content.php 93.33% <100.00%> (ø)
src/Constraint/Format.php 96.96% <100.00%> (+0.19%) :arrow_up:
src/Constraint/Type.php 93.65% <100.00%> (+42.85%) :arrow_up:
src/JsonSchema.php 100.00% <100.00%> (ø)
src/MagicMapTrait.php 83.78% <100.00%> (+5.40%) :arrow_up:
src/Wrapper.php 59.01% <100.00%> (+1.38%) :arrow_up:
src/Structure/ObjectItemTrait.php 73.84% <0.00%> (-2.35%) :arrow_down:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ec90855...3d82e48. Read the comment docs.