search

swaggest / php-json-schema

High definition PHP structures with JSON-schema based validation
MIT License
438 stars 50 forks source link

Permit installation when symfony/polyfill-mbstring is present #133

Closed cedric-anne closed 2 years ago

cedric-anne commented 2 years ago

I propose to require the symfony/polyfill-mbstring package, instead of the mbstring extension, to permit usage of this library on PHP server that does not have the extension loaded. For instance, it can happen on some shared hosting servers where users cannot choose which extension is installed.

codecov[bot] commented 2 years ago

Codecov Report

Merging #133 (a667a99) into master (ab7cca1) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files          27       27           
  Lines        1686     1686           
=======================================
  Hits         1562     1562           
  Misses        124      124

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ab7cca1...a667a99. Read the comment docs.

vearutop commented 2 years ago

Thank you!

cedric-anne commented 2 years ago

Thanks for the release.