search

swaggest / php-json-schema

High definition PHP structures with JSON-schema based validation
MIT License
438 stars 50 forks source link

Fix PHP 8.4 deprecations #163

Open cedric-anne opened 1 month ago

cedric-anne commented 1 month ago

Implicitly nullable parameter declarations are deprecated in PHP 8.4. The proposed change is safe and is not considered by PHP as a signature change, see https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

cedric-anne commented 1 month ago

This new syntax is compatible only with PHP >= 7.1. Would you accept a PR to drop the compatibility with these outdated PHP versions? What PHP versions should be kept?

cedric-anne commented 1 week ago

Ping @vearutop .

The deprecation warning on PHP 8.4 is preventing us to active our CI checks on this incoming PHP version. We could still apply manually a patch, but we would prefer to help to fix it in your lib directly.