search

swaggest / php-json-schema

High definition PHP structures with JSON-schema based validation
MIT License
451 stars 51 forks source link

Restore proper $ref handling in mapped classes (broken in v0.12.6) #78

Closed vearutop closed 5 years ago

vearutop commented 5 years ago

This PR fixes $ref property check that was broken few versions ago. The issue causes failure of https://github.com/swaggest/php-code-builder/blob/v0.2.7/tests/src/PHPUnit/Swagger/ImportTest.php#L12.

codecov[bot] commented 5 years ago

Codecov Report

Merging #78 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   90.31%   90.33%   +0.02%     
==========================================
  Files          27       27              
  Lines        1579     1583       +4     
==========================================
+ Hits         1426     1430       +4     
  Misses        153      153
Impacted Files Coverage Δ
src/Structure/ObjectItemTrait.php 80% <ø> (ø) :arrow_up:
src/Schema.php 95.08% <100%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e1fcf01...7311a8d. Read the comment docs.