search

swaggo / fiber-swagger

fiber middleware to automatically generate RESTful API documentation with Swagger 2.0.
MIT License
39 stars 12 forks source link

Update deps and tests #10

Open rhaist opened 1 year ago

rhaist commented 1 year ago

Describe the PR Update dependencies and adapt test

rhaist commented 1 year ago

So it seems like github.com/mattn/go-runewidth depends on github.com/rivo/uniseg which requires Go 1.18. I guess you don't want to require that as a minimum version for fiber-swagger ?

Based on https://endoflife.date/go I would recommend to upgrade the supported versions to 1.18 and 1.19.

codecov[bot] commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (913fa3f) compared to base (bba772b). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #10 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 59 59 ========================================= Hits 59 59 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=swaggo). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=swaggo)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ubogdan commented 1 year ago

@rhaist This package returns a fiber.Handler so you can use it with your project. Your PR simply drops support for anyone using an older version than go 1.18 which will introduce breaking changes.

For example, I use go 1.17 to build my projects for prod env.

By example we can drop version 1.15 to get in sync with swaggo/swag.