search

swaggo / swag

Automatically generate RESTful API documentation with Swagger 2.0 for Go.
MIT License
10.46k stars 1.19k forks source link

Feat: allow enum ordered const name override #1779

Open drewsilcock opened 5 months ago

drewsilcock commented 5 months ago

Describe the PR Add ability to override name of enum variant generated from ordered constant using // @name VariantName in the same way you can do for types.

Relation issue https://github.com/swaggo/swag/issues/1778

Additional context N/A

ubogdan commented 4 months ago

@drewsilcock Please rebase and update the code.

drewsilcock commented 4 months ago

Thanks for taking the time to take a look at this @ubogdan - I've rebased and updated based on the linter and your comments.

drewsilcock commented 2 months ago

@ubogdan @sdghchj Any chance of a re-review / merge? Would be great to get this in. Thanks in advance 🙂

sdghchj commented 2 months ago

I can't see the passed checks of all the tests. I am afraid I will be noticed again the test failure if I merge this PR.

drewsilcock commented 2 months ago

I can't see the passed checks of all the tests. I am afraid I will be noticed again the test failure if I merge this PR.

Is there something additional we need to do for the full test suite to run on this PR? (The tests pass just fine when I run it locally on Go v1.22.)

sdghchj commented 2 months ago

@ubogdan was requested to review。 long time no see him.

drewsilcock commented 2 months ago

Thanks for approving, I re-requested a review from @ubogdan after making the changes he requested, is his approval required for merging? GitHub seems to be blocking merge until the review request is approved or dismissed.