swagnercarena / paltas

Conduct simulation-based inference on strong gravitational lensing systems.
MIT License
13 stars 12 forks source link

Redshift input, lens light, and basics for population transformers #36

Closed swagnercarena closed 2 years ago

swagnercarena commented 2 years ago

A number of changes including:

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2702049276


Files with Coverage Reduction New Missed Lines %
../../../../../opt/hostedtoolcache/Python/3.8.13/x64/lib/python3.8/site-packages/paltas/Sources/cosmos.py 1 99.17%
../../../../../opt/hostedtoolcache/Python/3.8.13/x64/lib/python3.8/site-packages/paltas/Sources/galaxy_catalog.py 2 96.72%
../../../../../opt/hostedtoolcache/Python/3.8.13/x64/lib/python3.8/site-packages/paltas/Analysis/train_model.py 8 91.82%
../../../../../opt/hostedtoolcache/Python/3.8.13/x64/lib/python3.8/site-packages/paltas/Configs/config_handler.py 14 95.11%
<!-- Total: 25 -->
Totals Coverage Status
Change from base Build 2619708538: 0.8%
Covered Lines: 2277
Relevant Lines: 2395

💛 - Coveralls
swagnercarena commented 2 years ago

Thanks for all the great comments. I made changes to the code to address all of them. As for the new fc_inputs model, it's still very much in flux. I added an activation and batch normalization as you suggested, but we can implement a more reasonable model once we know what works well.