Fix train_model.py bug, fix Analysis module import

swagnercarena / paltas

Conduct simulation-based inference on strong gravitational lensing systems.

MIT License

13 stars 12 forks source link

Fix train_model.py bug, fix Analysis module import #39

Closed smericks closed 1 year ago

smericks commented 1 year ago

Fix bug for params_as_inputs in train_model.py
Fix relative import in train_model.py
Fix import of Analysis module in init.py

smericks commented 1 year ago

@swagnercarena I tried to reproduce the failed test (test_plot_coverage() in analysis tests), but I'm passing all tests on my machine. Any idea what's causing this?

smericks commented 1 year ago

Yes I agree that's a cleaner way to do it, I just made that change.

Ok I see, glad there's a fix on the way!

JelleAalbers commented 1 year ago

@swagnercarena Do you agree this is good to merge? Sorry, I should have asked you explicitly before approving.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3285470493

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 95.044%

Totals
Change from base Build 2702188126:	-0.03%
Covered Lines:	2282
Relevant Lines:	2401

Thanks for making these additions @smericks. I went ahead and included @JelleAalbers fix so that we didn't get failures on the main page (I also included a 0.1 decrease coverage threshold for failure since the 0% threshold was too strict).

swagnercarena / paltas

Fix train_model.py bug, fix Analysis module import #39

Pull Request Test Coverage Report for Build 3285470493

💛 - Coveralls