search

swagnercarena / paltas

Conduct simulation-based inference on strong gravitational lensing systems.
MIT License
13 stars 12 forks source link

paltas pip version not consistent with latest lenstronomy versions #48

Open sibirrer opened 10 months ago

sibirrer commented 10 months ago

the pip version of paltas causes an error when running with later versions of lenstronomy (the main branch is ok). Can you release a new paltas version? The line we are talking about is here: https://github.com/swagnercarena/paltas/blob/be74107f2e285f890d61fdd91f18dd07760fe085/paltas/MainDeflector/simple_deflectors.py#L67 (also, here you access a private lenstronomy function, which should be avoided)

swagnercarena commented 10 months ago

Hi Simon,

Thank you for the feedback!

I will release a new pip version and mark this issue as complete when it is done.

Is there a better way to get parameter names for an arbitrary profile in lenstronomy? I can make a feature request on lenstronomy if that would be useful.

sibirrer commented 10 months ago

Thank you Sebastian. I don't think there is currently a much better way. Perhaps we can have the function as a public function outside of the class and have more of the input arguments optional. That can make it easier for you.

sibirrer commented 10 months ago

I just merged a pull request to the lenstronomy main branch for a decoupled function of what you (hopefully) want: https://github.com/lenstronomy/lenstronomy/pull/543