swagnercarena / paltas

Conduct simulation-based inference on strong gravitational lensing systems.
MIT License
13 stars 12 forks source link

fix calls to lenstronomy for new version #54

Closed smericks closed 7 months ago

smericks commented 9 months ago
sibirrer commented 7 months ago

@swagnercarena this PR should be merged ASAP to guarantee consistency with lenstronomy. I think the issue with the test failing is that paltas required an older version of lenstronomy

swagnercarena commented 7 months ago

@smericks, can you modify the lenstronomy requirements to the new pip version with this change? That should also trigger the tests to run again.

smericks commented 7 months ago

@swagnercarena @sibirrer So the switch from_import_class() to lens_class() happened Oct 27th (https://github.com/lenstronomy/lenstronomy/commit/f815d0694dd55b3afc224cb30cd3f226515090c5)

But the latest pip version of lenstronomy is from Sep 28th (https://github.com/lenstronomy/lenstronomy/releases/tag/v1.11.5)

So I don't think this change is compatible with a pip release of lenstronomy yet. Since I'm working with more up to date lenstronomy than the pip release, I tried to jump the gun on changing this.

swagnercarena commented 7 months ago

Okay, let's circle back to this pull request once the newest pip version of lenstronomy is compatible with the change. Thanks @smericks!

sibirrer commented 7 months ago

Okay, let's circle back to this pull request once the newest pip version of lenstronomy is compatible with the change. Thanks @smericks!

ah, I see. On my way for a new lenstronomy release and then ping here. Thank you!

sibirrer commented 7 months ago

@smericks @swagnercarena lenstronomy version 1.11.6 is available on pip

coveralls commented 7 months ago

Coverage Status

coverage: 94.973%. remained the same when pulling 9956d0506cc11e92267a9afe6ae009f25fb20c38 on smericks:updated_lenstronomy into 6f6e9ecdbb59cf10f59620ce07350f01037548b3 on swagnercarena:main.