search

swagnercarena / paltas

Conduct simulation-based inference on strong gravitational lensing systems.
MIT License
13 stars 12 forks source link

Bug fix: Truncated Redshift distribution #59

Closed P-1884 closed 1 month ago

P-1884 commented 1 month ago

Fix for minor bug for the RedshiftsTruncNorm class

Description of Bug: The lower source redshift truncation value (self.z_source_min) is updated dependent on the lens redshift, but is not reset to the default/inputted value after each draw. Therefore the truncation value gradually increases as more draws are made. Fix: The lower truncation value is now set to the inputted value (self.z_source_min_default) in the cases that it is greater than the lens redshift.

swagnercarena commented 1 month ago

I think changing the naming as I suggested should fix the merge conflict, but we can take another look if it doesn't

coveralls commented 1 month ago

Coverage Status

coverage: 85.656% (-9.3%) from 94.973% when pulling 66dc8c67d563e97686da9455da080e67e9a18163 on P-1884:Truncated-redshift-distribution-fix into 5405f4ac84ce6aa0576da1cf18b7f07ad40dd757 on swagnercarena:main.