os[windows] was not included in the list; let's see what we need - Githubissues

swalberg / chef-f5

An F5 Chef cookbook to manage pools and VIPs on an F5 bigip

MIT License

5 stars 5 forks source link

os[windows] was not included in the list; let's see what we need #13

Closed davidalpert closed 7 years ago

davidalpert commented 7 years ago

Problem

    ArgumentError
    ---------------
    You must supply a name when declaring a package resource.

    Cookbook Trace
    ----------------
    c:/chef/cache/cookbooks/f5/libraries/gem_helper.rb:16:in 'install_f5_gem'
    c:/chef/cache/cookbooks/f5/libraries/gem_helper.rb:4:in 'install_f5_gem'
    c:/chef/cache/cookbooks/f5/resources/pool:13:in 'block in class_from_file'

Root cause

When converging and using f5 resources on a node where 'node['platform_family']` was not one of:

rhel
fedora
amazon
suse
debian this error would occur because packages would be nil at line 16 (due to the when case statement excluding alternative cases, such as windows)

Fix

ensure that we only call that package resource when we have packages to install.

Test cases

successfully converged a recipe using the f5_pool and f5_vip resources on a Windows 2012R2 instance in test kitchen; it turns out this referencing this cookbook is sufficient to install the required dependencies to use these resources on a Windows node.

davidalpert commented 7 years ago

last commit went red b/c I squash/merged this PR before the build could download it.