search

swalberg / chef-f5

An F5 Chef cookbook to manage pools and VIPs on an F5 bigip
MIT License
5 stars 5 forks source link

Allow to specify partitions in resources. #32

Closed Tensibai closed 5 years ago

Tensibai commented 5 years ago

To be able to properly create resources (mostly pools and nodes) in a specific partition different than Common.

By default Common is the partition used to get_list of pools and nodes. This patch fix that.

(Next pull request include this change and various style and test fixes to math actual cookstyle linting)

swalberg commented 5 years ago

Hi, thanks for this PR. We don't use partitions, so I'm glad someone that does is able to add the functionality in.

The tests are failing since there's now an extra API call that needs to be stubbed out. Would you be able to fix that up, please?

Thanks,

Sean

Tensibai commented 5 years ago

@swalberg I made this PR just to show the minimal change, I did the other, #33, with the whole change and all I did to comply with Chef actual style and using delivery local verify to do the syntax, lint and unit tests.

I thought it would be easier to understand the change in isolation as my commits are a bit messy :p This one could be closed I think.