search

swami / libinstpatch

Instrument file software library.
Other
20 stars 6 forks source link

Invalid library in libinstpatch.pc #10

Closed jjceresa closed 5 years ago

jjceresa commented 5 years ago

Actually in libinstpatch.pc, the following line describe two library: libinstpatch-0.lib and m.lib

Libs: -L${libdir} -llibinstpatch-0 -lm

Linking libswami target, to libinstpatch library leads to error: m.lib not found.

Please, does this option -lm really useful on Linux ?

derselbst commented 5 years ago

Correct, -lm is only required on Linux. This will probably be fixed once I've set up CI builds for Linux and Windows.

jjceresa commented 5 years ago

This will probably be fixed once I've set up CI builds for Linux and Windows.

Does this shouldn't be fixed rather in CMakeLists.txt that generate libinstpatch.pc from libinstpatch.pc.in ?

derselbst commented 5 years ago

Sure. I was just trying to say that I only see those windows related issues once CI builds are setup and take care of fixing them appropriately.

jjceresa commented 5 years ago

I will propose a PR to fix that.