search

swami / libinstpatch

Instrument file software library.
Other
20 stars 6 forks source link

GLib parser #24

Closed jjceresa closed 5 years ago

jjceresa commented 5 years ago

This PR replace PR https://github.com/swami/libinstpatch/pull/23 which must be ignored.

Getopt support is removed from CMakeLists.txt. riff_dump command line executable makes use of Glib options parser instead of getopt.
This fix #19.

derselbst commented 5 years ago

Thanks. I've fixed a use after free which occurred when using file_name in fprintf() after g_strfreev (file_arg). Also, please never introduce unnecessary white space changes. This makes it really hard to comprehend what has actually changed. It's not worth the hassle, as we have a tool for that. I'll draft a PR for a complete reformat.

And I re-added the call to g_type_init().

jjceresa commented 5 years ago

I'll draft a PR for a complete reformat.

Thanks for that. This will be very useful as I've started documenting partly libinstpatch's source files. I'd be grateful for a complete reformat before continuing this documentation.