swami / libinstpatch

Instrument file software library.
Other
20 stars 6 forks source link

Fix pkgconfig libname when cross compiling with mingw under Linux #36

Closed realnc closed 4 years ago

realnc commented 4 years ago

When trying to link against the library while cross-compiling with mingw under Linux, the result is:

cannot find -llibinstpatch-2

Try to fix this by letting cmake handle the library filename prefix and never use a prefix in the .pc file.

derselbst commented 4 years ago

Sorry, but this breaks fluidsynth's build and possibly every other application that wants to link against libinstpatch on Windows:

https://dev.azure.com/tommbrt/tommbrt/_build/results?buildId=1261&view=logs&j=80e0b353-48d4-5cda-beb4-2a5a682bf525&t=71d522da-38a9-5ba1-1edf-9e925348b8c4

realnc commented 4 years ago

Then I'm not sure what to do :-/ The current cmake file breaks mingw in Linux.

realnc commented 4 years ago

Pushed attempt number 2. Let cmake decide on the libname prefix and have the pkgconfig file never use a prefix.

derselbst commented 4 years ago

Perfect. Fluidsynth's build is also green. Thank you!