fix 1: issue that occurs when a IpatchSF2VoiceCache object is freed.
For example using swami:
After loading a soundfont , playing some notes on one instrument zone than playing notes on another instrument zone,... such a IpatchSF2VoiceCache is used by the fluidsynth plugin. Then when the application exits this IpatchSF2VoiceCache is freed when voice_cache_hash is freed. This produces most critical messages:
This is because whenIpatchSF2VoiceCache is freed, ipatch_sample_store_cache_close(store)is called (via cache->voice_user_data_destroy()) and storeparameter is no more valid because it is already freed before cache->voice_user_data_destroy()is called.
To fix this issue, the ordering of operation in ipatch_sf2_voice_cache_finalize() is changed to
ensure that voice_user_data_destroy() function can work properly.
fix 2: For coherency with the change done in fix 1, cache->user_data_destroy ordering is changed also.
derselbst
commented
4 years ago
This PR fixes 3 issues
fix 1: issue that occurs when a
IpatchSF2VoiceCacheobject is freed.For example using swami:
After loading a soundfont , playing some notes on one instrument zone than playing notes on another instrument zone,... such a
IpatchSF2VoiceCacheis used by thefluidsynth plugin. Then when the application exits thisIpatchSF2VoiceCacheis freed whenvoice_cache_hashis freed. This produces most critical messages:** (swami1.exe:7248): CRITICAL **: file ..IpatchSampleStoreCache.c: line 306: assertion IPATCH_IS_SAMPLE_STORE_CACHE (store) failedThis is because when
IpatchSF2VoiceCacheis freed,ipatch_sample_store_cache_close(store)is called (viacache->voice_user_data_destroy()) andstoreparameter is no more valid because it is already freed beforecache->voice_user_data_destroy()is called.To fix this issue, the ordering of operation in
ipatch_sf2_voice_cache_finalize()is changed to ensure thatvoice_user_data_destroy()function can work properly.fix 2: For coherency with the change done in
fix 1,cache->user_data_destroyordering is changed also.fix 3: free
overides_modslist.