search

swan-cern / jupyterhub-extensions

Customized components of the Jupyterhub server in SWAN (handlers, spawners, templates).
GNU Affero General Public License v3.0
26 stars 14 forks source link

Problems with get_roles_for_token #36

Closed rmalik2018 closed 3 years ago

rmalik2018 commented 3 years ago

Hello,

I have added one more configurable parameter for claim_roles_key as per the issue : https://github.com/swan-cern/jupyterhub-extensions/issues/35

Regards,

Rakesh Malik

diocas commented 3 years ago

Hi @rmalik2018 sorry for the delay. This way seems a bit hardcoded and I don't this this is the best option. I would prefer something more configurable, like giving a path inside the object, and use it to fetch the value.

diocas commented 3 years ago

Replaced by #37