swan-io / react-native-browser

An easy-to-use in-app browser module for React Native, powered by Chrome Custom Tabs / SFSafariViewController.
MIT License
132 stars 9 forks source link

fix: make NSNumber nonnull on iOS #5

Closed huextrat closed 5 months ago

huextrat commented 5 months ago

Summary

fixes: https://github.com/swan-io/react-native-browser/issues/4

There's probably a better way than setting -1 to avoid this error, but I'm not sure what the right behavior to handle nullable NSNumber correctly on libraries.

Test Plan

What's required for testing (prerequisites)?

What are the steps to test it (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

zoontek commented 5 months ago

Thanks, but fixed in #6 and available in 0.2.1