swan-io / react-native-browser

An easy-to-use in-app browser module for React Native, powered by Chrome Custom Tabs / SFSafariViewController.
MIT License
132 stars 9 forks source link

Android build error (isTurboModule) #7

Closed marekp97 closed 5 months ago

marekp97 commented 5 months ago

Before submitting a new issue

Bug summary

Hey, when building Android I get an error:

error: constructor ReactModuleInfo in class ReactModuleInfo cannot be applied to given types;
 ReactModuleInfo moduleInfo = new ReactModuleInfo(
                                    ^
 required: String,String,boolean,boolean,boolean,boolean,boolean
 found: String,String,boolean,boolean,boolean,boolean
 reason: actual and formal argument lists differ in length

In @swan-io/react-native-browser/android/src/main/java/io/swan/rnbrowser/RNSwanBrowserPackage.java:32 add the boolean isTurboModule.

I added something like this and it works:

ReactModuleInfo moduleInfo = new ReactModuleInfo(
 RNSwanBrowserModuleImpl.NAME,
 RNSwanBrowserModuleImpl.NAME,
 false,
 false,
 false,
 BuildConfig.IS_NEW_ARCHITECTURE_ENABLED,
 false
);

Can you fix it as quickly as possible?

Library version

0.2.1

Environment info

System:
  OS: macOS 14.4.1
  CPU: (8) arm64 Apple M1
  Memory: 89.98 MB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.5.0
    path: /private/var/folders/sq/w2vd9vmd5wxg02kq33t6p2w80000gn/T/xfs-502ed620/node
  Yarn:
    version: 3.1.1
    path: /private/var/folders/sq/w2vd9vmd5wxg02kq33t6p2w80000gn/T/xfs-502ed620/yarn
  npm:
    version: 9.8.0
    path: /opt/homebrew/bin/npm
  Watchman:
    version: 2023.07.24.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.12.1
    path: /usr/local/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.0
      - iOS 17.0
      - macOS 14.0
      - tvOS 17.0
      - watchOS 10.0
  Android SDK: Not Found
IDEs:
  Android Studio: 2023.2 AI-232.10300.40.2321.11567975
  Xcode:
    version: 15.0/15A240d
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.7
    path: /usr/bin/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.72.0-rc.3
    wanted: 0.72.0-rc.3
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Steps to reproduce

Run Android build.

Reproducible sample code

Isn't needed?
zoontek commented 5 months ago

Fixed in 0.2.2