search

swanandx / rustywitness

A CLI tool for getting screenshots of URLs using headless chrome
MIT License
27 stars 6 forks source link

add option to size! #1

Open 0xhunster opened 1 year ago

0xhunster commented 1 year ago

I hope you are doing well! could you update the script to add a new option like screenshot size?

swanandx commented 1 year ago

Hey, Added option to specify size, can you verify it by building from source? currently I added -h/--height and -w/--width. what do u think just -s/--size width,height be a better option?

PS: Thnx for opening this issue, I thought no one was using it so kinda stopped working on it haha

0xhunster commented 1 year ago

hahaha I thought many people using this script. chill brother. I am searching for a rust-based screenshot script. because gowitness is a very noisy output. Always I like to have minimal output script. finally, I got it from Twitter, but mistakenly I lost your script, then I search more and more, finally got it. and I saw good output showing. without any extra text or error. like it 👍🏻.

I said size, sorry for that. size means height/width. I am using it regularlly 🥰 but one thing I saw screenshot quality not well :(. I will let you know your option work or not.

Thanks brother ♥♥♥

swanandx commented 1 year ago

Thank you, it feels so good to know that someone likes what you are building <3 Let me know once you try it, then I will release it ASAP.

btw, wdym by screenshot quality? is it taking screenshot before whole site is loaded or do you mean about resolution? If its later part, I think it will be taken care of when you specify height/width? gowitness uses chromedp and I couldn't find any good alternative for it in rust, headless_chrome works but it isn't async, so currently i'm using chromiumoxide. So yeah, some thing might not be that great yet.

Please feel free to open issues if you are facing some other difficulties!

0xhunster commented 1 year ago

error showing.

image

swanandx commented 1 year ago

I will take a look! it is related to chromiumoxide ig

0xhunster commented 1 year ago

Any update? Did you fix this issue?

swanandx commented 1 year ago

No updates yet 😕

swanandx commented 1 year ago

@0xhunster I did try on my machine ( even with brave browser ), it seemed to work just fine! can u just confirm once u are using latest code from main brance?

0xhunster commented 1 year ago

sorry for the late response. Brother, you can push the latest version.