search

swanpenguin / Reddit-Post-Game-Thread-Generator

MIT License
4 stars 2 forks source link

ESPN changed their college football format. #6

Open Rumel opened 8 years ago

Rumel commented 8 years ago

screen shot 2015-08-30 at 4 28 16 pm

screen shot 2015-08-30 at 4 28 59 pm

Rumel commented 8 years ago

@swanpenguin We should probably make a separate generator for each of the sports. We could move to a structure like this:

/lib
  /espn_box_score
    ncf.rb
    nba.rb
    ncb.rb
    ncw.rb
  espn_box_score.rb

espn_box_score.rb would do a url match and then hand off to the generator and return. We could also add a utilities file for shared code. I think we might be able to write some helper functions to dry up the xpath code.

swanpenguin commented 8 years ago

@Rumel I agree with you. That would be a good model. I think we should adopt it. Further, I got rid of the Top Performers portion of the created post. It can be replaced easily with another part of the data. There is some data when you use /game? instead of /boxscore? in the url.

It would be awesome if we could get some gifs or vids of highlights of the game, but... would probably need another data source.